[v3-2-test] Fix connection schema field not saved for providers without field behaviour (#65263)#65267
Merged
Merged
Conversation
kaxil
marked this pull request as ready for review
April 14, 2026 23:12
kaxil
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
April 14, 2026 23:12
vatsrahul1001
marked this pull request as draft
April 15, 2026 03:58
vatsrahul1001
marked this pull request as ready for review
April 15, 2026 08:32
Contributor
|
Marked for 3.2.2 milestone do not merge for now |
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
April 15, 2026 08:54
b7b4ac6 to
f0ad43b
Compare
vatsrahul1001
requested review from
RNHTTR,
amoghrajesh,
ashb,
bugraoz93,
dabla,
ephraimbuddy,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
jscheffl,
kaxil,
potiuk,
shahar1 and
vincbeck
as code owners
April 15, 2026 08:54
vatsrahul1001
requested review from
XD-DENG,
dheerajturaga and
rawwar
as code owners
April 15, 2026 08:54
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
April 15, 2026 16:35
28a8ef5 to
18a3932
Compare
Contributor
|
rebase went wrong |
vatsrahul1001
force-pushed
the
backport-bb8971d-v3-2-test
branch
from
April 16, 2026 10:53
af12221 to
4412c6f
Compare
Contributor
Rebased |
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
April 17, 2026 17:14
f7c41f9 to
5560e7c
Compare
vatsrahul1001
force-pushed
the
v3-2-test
branch
2 times, most recently
from
April 23, 2026 05:03
075c4fc to
3fe9a9a
Compare
vatsrahul1001
force-pushed
the
backport-bb8971d-v3-2-test
branch
from
April 23, 2026 05:35
4412c6f to
9e1f79b
Compare
…group (#65150) (#65160) Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script). Updates `actions/github-script` from 8.0.0 to 9.0.0 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) (cherry picked from commit e5a047c) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5118) (#65242) * Move release calendar verification to its own scheduled workflow Run dev/verify_release_calendar.py from a dedicated daily scheduled workflow instead of as a canary job in the main CI pipeline, and notify the #release-management Slack channel when the check fails so the issue is surfaced to release managers directly. * Include wiki and calendar links in release calendar Slack alert (cherry picked from commit 048e9a1)
…group (#65150) (#65160) Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script). Updates `actions/github-script` from 8.0.0 to 9.0.0 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) (cherry picked from commit e5a047c) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5118) (#65242) * Move release calendar verification to its own scheduled workflow Run dev/verify_release_calendar.py from a dedicated daily scheduled workflow instead of as a canary job in the main CI pipeline, and notify the #release-management Slack channel when the check fails so the issue is surfaced to release managers directly. * Include wiki and calendar links in release calendar Slack alert (cherry picked from commit 048e9a1)
…ut field behaviour (#65263) When a provider (e.g. Oracle) does not define get_ui_field_behaviour(), the API returns standard_fields: null. The convertStandardFields function returned the raw default fields dict which uses `url_schema` as the key. The form then registered a Controller named "url_schema" instead of "schema", so user input never reached the schema field in the request body. On create, schema defaulted to None. On edit, the extra url_schema key caused a 422 from the StrictBaseModel extra="forbid" validation. Remap url_schema to schema in the null branch, matching the non-null path. (cherry picked from commit bb8971d) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Closes: #65257
potiuk
force-pushed
the
backport-bb8971d-v3-2-test
branch
from
April 26, 2026 16:56
9e1f79b to
fd5796f
Compare
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 27, 2026
…ut field behaviour (#65263) (#65267) * [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160) Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script). Updates `actions/github-script` from 8.0.0 to 9.0.0 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) (cherry picked from commit e5a047c) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241) * Add breeze generate issue content for airflow-ctl * add new command to doc (cherry picked from commit b24538b) Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> * [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242) * Move release calendar verification to its own scheduled workflow Run dev/verify_release_calendar.py from a dedicated daily scheduled workflow instead of as a canary job in the main CI pipeline, and notify the #release-management Slack channel when the check fails so the issue is surfaced to release managers directly. * Include wiki and calendar links in release calendar Slack alert (cherry picked from commit 048e9a1) * [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160) Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script). Updates `actions/github-script` from 8.0.0 to 9.0.0 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) (cherry picked from commit e5a047c) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241) * Add breeze generate issue content for airflow-ctl * add new command to doc (cherry picked from commit b24538b) Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> * [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242) * Move release calendar verification to its own scheduled workflow Run dev/verify_release_calendar.py from a dedicated daily scheduled workflow instead of as a canary job in the main CI pipeline, and notify the #release-management Slack channel when the check fails so the issue is surfaced to release managers directly. * Include wiki and calendar links in release calendar Slack alert (cherry picked from commit 048e9a1) * [v3-2-test] Fix connection schema field not saved for providers without field behaviour (#65263) When a provider (e.g. Oracle) does not define get_ui_field_behaviour(), the API returns standard_fields: null. The convertStandardFields function returned the raw default fields dict which uses `url_schema` as the key. The form then registered a Controller named "url_schema" instead of "schema", so user input never reached the schema field in the request body. On create, schema defaulted to None. On edit, the extra url_schema key caused a 422 from the StrictBaseModel extra="forbid" validation. Remap url_schema to schema in the null branch, matching the non-null path. (cherry picked from commit bb8971d) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Closes: #65257 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
May 20, 2026
…ut field behaviour (#65263) (#65267) * [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160) Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script). Updates `actions/github-script` from 8.0.0 to 9.0.0 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) (cherry picked from commit e5a047c) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241) * Add breeze generate issue content for airflow-ctl * add new command to doc (cherry picked from commit b24538b) Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> * [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242) * Move release calendar verification to its own scheduled workflow Run dev/verify_release_calendar.py from a dedicated daily scheduled workflow instead of as a canary job in the main CI pipeline, and notify the #release-management Slack channel when the check fails so the issue is surfaced to release managers directly. * Include wiki and calendar links in release calendar Slack alert (cherry picked from commit 048e9a1) * [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160) Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script). Updates `actions/github-script` from 8.0.0 to 9.0.0 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@ed59741...3a2844b) (cherry picked from commit e5a047c) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions-updates ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241) * Add breeze generate issue content for airflow-ctl * add new command to doc (cherry picked from commit b24538b) Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> * [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242) * Move release calendar verification to its own scheduled workflow Run dev/verify_release_calendar.py from a dedicated daily scheduled workflow instead of as a canary job in the main CI pipeline, and notify the #release-management Slack channel when the check fails so the issue is surfaced to release managers directly. * Include wiki and calendar links in release calendar Slack alert (cherry picked from commit 048e9a1) * [v3-2-test] Fix connection schema field not saved for providers without field behaviour (#65263) When a provider (e.g. Oracle) does not define get_ui_field_behaviour(), the API returns standard_fields: null. The convertStandardFields function returned the raw default fields dict which uses `url_schema` as the key. The form then registered a Controller named "url_schema" instead of "schema", so user input never reached the schema field in the request body. On create, schema defaulted to None. On edit, the extra url_schema key caused a 422 from the StrictBaseModel extra="forbid" validation. Remap url_schema to schema in the null branch, matching the non-null path. (cherry picked from commit bb8971d) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Closes: #65257 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a provider (e.g. Oracle) does not define get_ui_field_behaviour(),
the API returns standard_fields: null. The convertStandardFields function
returned the raw default fields dict which uses
url_schemaas the key.The form then registered a Controller named "url_schema" instead of
"schema", so user input never reached the schema field in the request body.
On create, schema defaulted to None. On edit, the extra url_schema key
caused a 422 from the StrictBaseModel extra="forbid" validation.
Remap url_schema to schema in the null branch, matching the non-null path.
(cherry picked from commit bb8971d)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com
Closes: #65257